Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libpq: init at 17.2 #359659

Open
wants to merge 5 commits into
base: staging
Choose a base branch
from
Open

libpq: init at 17.2 #359659

wants to merge 5 commits into from
+382 −223

Conversation

wolfgangwalther
Copy link
Contributor

@wolfgangwalther wolfgangwalther commented Nov 27, 2024 •
edited
Loading

This creates a separate libpq package as discussed in #61580 (comment).

This brings down the number of rebuilds after updating postgresql to about 1.2k darwin and 2.5k linux. Before, they were ~ around 5k, IIRC.

Unfortunately, we are still not anywhere low enough to be able to merge postgresql updates directly into master. I think the nr. 1 reason for that is postgresqlTestHook - and the fact that many packages use a very simple postgresql server in their build dependencies for the check phase.

The only way to get the number of rebuilds lower would be to package postgresqlTestHook as a separate postgresql derivation. The idea would be, that security related issues are irrelevant for the check phase of other packages - and thus updating this separately could easily go through staging with a certain delay. This derivation could also be one that is built with the minimal feature set, making it slimmer overall.

I still think that introducing libpq is a good thing on it's own, thus this PR.

Closes #61580 and #191920

Things done

  • Built on platform(s)
    • x86_64-linux (the directly changed packages)
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 28, 2024
@wolfgangwalther wolfgangwalther force-pushed the postgresql-libpq branch 2 times, most recently from 1eb5366 to 862bd30 Compare November 28, 2024 18:48
@wolfgangwalther wolfgangwalther removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Nov 28, 2024
@nix-owners nix-owners bot requested a review from ttuegel December 14, 2024 14:57
@wolfgangwalther
Copy link
Contributor Author

Rebased to resolve the many merge conflicts after nixfmt has been run on a lot files in the meantime.

@Ma27 will still review, so not ready, yet.

@wolfgangwalther wolfgangwalther force-pushed the postgresql-libpq branch 2 times, most recently from aa9fe51 to b6a4e7c Compare December 14, 2024 15:09
philiptaron
philiptaron approved these changes Dec 14, 2024
View reviewed changes
pkgs/by-name/ps/psqlodbc/package.nix Outdated Show resolved Hide resolved
@wegank wegank added 12.approvals: 2 This PR was reviewed and approved by two reputable people and removed 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Dec 15, 2024
@ofborg ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-linux: 501+ and removed 2.status: merge conflict This PR has merge conflicts with the target branch labels Dec 15, 2024
@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Dec 31, 2024
@wolfgangwalther
Copy link
Contributor Author

Rebased to resolve merge conflicts.

@wolfgangwalther wolfgangwalther removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 1, 2025
@wegank wegank removed the 12.approvals: 2 This PR was reviewed and approved by two reputable people label Jan 1, 2025
@Ma27
Copy link
Member

Ma27 commented Jan 1, 2025

I promise, I haven't forgotten about that, I'll do my best to schedule a review soon! :))

@wegank wegank added the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 4, 2025
@wolfgangwalther
psqlodbc: adopt with NixOS/postgres team
9f61d0a 
Since psqlodbc is an official upstream project, we should take ownership
of it.
@wolfgangwalther
psqlodbc: 16.00.0000 -> 17.00.0002
0bd6cca 
The latest version is not available from odbc/versions.old/.., thus move
to fetchFromGitHub.

No changelog found anywhere.
@wolfgangwalther
psqlodbc: add updateScript
0045bc5
@wolfgangwalther
hydra: postgresql is a check dependency only
4961784
@wolfgangwalther
libpq: init at 17.2
bc79bc4 
Resolves NixOS#61580
@wolfgangwalther wolfgangwalther removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Jan 11, 2025
@wolfgangwalther wolfgangwalther mentioned this pull request Jan 13, 2025
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@szlend szlend szlend approved these changes

@philiptaron philiptaron philiptaron approved these changes

@aanderse aanderse Awaiting requested review from aanderse

@drupol drupol Awaiting requested review from drupol

@figsoda figsoda Awaiting requested review from figsoda

@globin globin Awaiting requested review from globin

@infinisil infinisil Awaiting requested review from infinisil

@jtojnar jtojnar Awaiting requested review from jtojnar

@K900 K900 Awaiting requested review from K900

@Ma27 Ma27 Awaiting requested review from Ma27

@mmahut mmahut Awaiting requested review from mmahut

@NickCao NickCao Awaiting requested review from NickCao

@RaghavSood RaghavSood Awaiting requested review from RaghavSood

@SuperSandro2000 SuperSandro2000 Awaiting requested review from SuperSandro2000

@talyz talyz Awaiting requested review from talyz

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: continuous integration Affects continuous integration (CI) in Nixpkgs, including Ofborg and GitHub Actions 6.topic: games 6.topic: lua 6.topic: ocaml 6.topic: php 6.topic: python 6.topic: qt/kde 6.topic: ruby 6.topic: rust 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1001-2500 10.rebuild-linux: 2501-5000
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@wolfgangwalther @Ma27 @philiptaron @szlend @wegank